- fixed generation of random negative numbers causing the pick_random…

…_fd method to fail.
iotivity · Jun 13, 2024 · 30cace2 · 30cace2
1 parent 4b254d8
commit 30cace2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/port/android/ipadapter.c b/port/android/ipadapter.c
@@ -815,7 +815,7 @@ static int
 pick_random_fd(const fd_set *sourcefds, int fd_count, int max_fd)
 {
   assert(fd_count > 0);
-  int random_rfd = (int)oc_random_value() % fd_count;
+  int random_rfd = (int)(oc_random_value() % fd_count);
   for (int i = 0; i <= max_fd; i++) {
     if (FD_ISSET(i, sourcefds)) {
       if (--fd_count == random_rfd) {

diff --git a/port/esp32/adapter/src/ipadapter.c b/port/esp32/adapter/src/ipadapter.c
@@ -840,7 +840,7 @@ static int
 pick_random_fd(const fd_set *sourcefds, int fd_count, int max_fd)
 {
   assert(fd_count > 0);
-  int random_rfd = (int)oc_random_value() % fd_count;
+  int random_rfd = (int)(oc_random_value() % fd_count);
   for (int i = 0; i <= max_fd; i++) {
     if (FD_ISSET(i, sourcefds)) {
       if (--fd_count == random_rfd) {

diff --git a/port/linux/ipadapter.c b/port/linux/ipadapter.c
@@ -937,7 +937,7 @@ static int
 pick_random_fd(const fd_set *sourcefds, int fd_count, int max_fd)
 {
   assert(fd_count > 0);
-  int random_rfd = (int)oc_random_value() % fd_count;
+  int random_rfd = (int)(oc_random_value() % fd_count);
   for (int i = 0; i <= max_fd; i++) {
     if (FD_ISSET(i, sourcefds)) {
       if (--fd_count == random_rfd) {