Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Draft: Milestone Stage #1696

Open
wants to merge 57 commits into
base: Dyrell-Milestone-Stage-Draft
Choose a base branch
from

Conversation

DyrellC
Copy link
Contributor

@DyrellC DyrellC commented Dec 24, 2019

Description

A draft of the new pipeline for milestone solidification. This consolidates the services provided in the LatestMilestoneTracker, LatestSolidMilestoneTracker and MilestoneSolidifier into just one class that all utilise the same pool of milestone candidate queues, and submits received milestones immediately on storage to be processed through the MilestonStage. This includes the solidification process introduced in #1646

Fixes #1688

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested by loading from local snapshots of various depths and ensuring that nodes solidify properly.
  • Awaiting buildkite tests for regression.
  • Unit tests have passed

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

DyrellC and others added 30 commits October 14, 2019 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant