Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Fix: Stop submitting zero value bundles as a task into the SpentAddressesService #1614

Merged
merged 11 commits into from
Jan 17, 2020
Merged

Fix: Stop submitting zero value bundles as a task into the SpentAddressesService #1614

merged 11 commits into from
Jan 17, 2020

Conversation

luca-moser
Copy link
Member

Description

Stops submitting zero value bundles into the SpentAddressesService.

Fixes # (issue)
#1613

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

Telekinesis.

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@luca-moser luca-moser changed the title Fix: Fixes zero value bundles getting submitted into the SpentAddressesService Fix: Stop submitting zero value bundles as a task into the SpentAddressesService Sep 11, 2019
@luca-moser luca-moser force-pushed the fix-spentaddressesservice-submit branch from bd77c3f to 9b12d2f Compare September 11, 2019 14:56
GalRogozinski
GalRogozinski reviewed Sep 11, 2019
View reviewed changes
Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add small unit test that verifies that spentAddressesProvider.saveAddressesBatch is not called

@luca-moser luca-moser force-pushed the fix-spentaddressesservice-submit branch 4 times, most recently from faf6a41 to 8f2a242 Compare September 11, 2019 16:03
@iotaledger iotaledger deleted a comment Sep 12, 2019
@luca-moser luca-moser force-pushed the fix-spentaddressesservice-submit branch from 8f2a242 to 7ef573f Compare October 2, 2019 11:48
@iotaledger iotaledger deleted a comment Oct 2, 2019
@iotaledger iotaledger deleted a comment Oct 3, 2019
@luca-moser luca-moser requested a review from kwek20 October 3, 2019 09:05
@GalRogozinski GalRogozinski mentioned this pull request Jan 6, 2020
Open
@iotaledger iotaledger deleted a comment from kwek20 Jan 7, 2020
@DyrellC DyrellC mentioned this pull request Jan 15, 2020
Open
4 tasks
@GalRogozinski GalRogozinski merged commit 26b15f9 into iotaledger:dev Jan 17, 2020
@GalRogozinski GalRogozinski mentioned this pull request Jan 20, 2020
Closed
@GalRogozinski GalRogozinski mentioned this pull request May 6, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GalRogozinski GalRogozinski GalRogozinski approved these changes

@kwek20 kwek20 Awaiting requested review from kwek20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luca-moser @GalRogozinski @DyrellC