Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(explorer): reduce space of owned objects if there isn't many #4192

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat(explorer): reduce space of owned objects if there isn't many #4192

wants to merge 2 commits into from
+91 −41

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Nov 22, 2024

Fixes #4166

@VmMad VmMad added team-tooling Issues related to the Tooling team explorer Issues related to the Explorer labels Nov 22, 2024
@VmMad VmMad requested review from a team as code owners November 22, 2024 10:18
@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: b3ed346

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-jw1a9zdse.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: f566069

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-c3j2zk4jx.vercel.app

evavirseda
evavirseda approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐

cpl121
cpl121 requested changes Nov 22, 2024
View reviewed changes
apps/explorer/src/lib/ui/enums/ownedObjects.enums.ts
Comment on lines +5 to +6
Sm = 'h-[500px]',
Md = 'h-[600px]',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having some problems with some size

image
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

marc2332
marc2332 requested changes Nov 22, 2024
View reviewed changes
apps/explorer/src/components/owned-objects/OwnedObjects.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to set the height in the parent component, can't we do it in this one? I am referring about the setContainerHeight strategy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 requested changes

@marc2332 marc2332 marc2332 requested changes

@evavirseda evavirseda evavirseda approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
explorer Issues related to the Explorer team-tooling Issues related to the Tooling team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce space in address view
4 participants
@VmMad @marc2332 @evavirseda @cpl121