Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Add hook with logic to check if an asset is 'Transferabe'. #4159

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat(core): Add hook with logic to check if an asset is 'Transferabe'. #4159

wants to merge 3 commits into from
+67 −26

Conversation

msarcev
Copy link
Contributor

@msarcev msarcev commented Nov 20, 2024

Description of change

  • Add new hook way
  • Remove old util function way

Links to any relevant issues

Closes #3962

@msarcev msarcev added the team-tooling Issues related to the Tooling team label Nov 20, 2024
@msarcev msarcev requested review from a team as code owners November 20, 2024 11:47
@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 306d178

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-gjwqgkhkp.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 306d178

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-5aycgvy42.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 306d178

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-mwheq3eim.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: f922246

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-k1u63k2b6.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: f922246

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-9g76m5iuj.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: f922246

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-1vmox2c50.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 98d9e72

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-pkoh8xaqw.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 98d9e72

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-1yncvxige.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 98d9e72

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-a3ihx0a83.vercel.app

@begonaalvarezd begonaalvarezd added the wallet Issues related to the IOTA Wallet label Nov 20, 2024
brancoder
brancoder requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancoder brancoder brancoder requested changes

@marc2332 marc2332 Awaiting requested review from marc2332

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
team-tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update isAssetTransferable logic to use getNormalizedMoveStruct
3 participants
@msarcev @brancoder @begonaalvarezd