Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-kit): improve UI Kit components darkmode #4140

Open
wants to merge 5 commits into
base: tooling-explorer/add-darkmode-support
Choose a base branch
from
Open

feat(ui-kit): improve UI Kit components darkmode #4140

wants to merge 5 commits into from
+16 −4

Conversation

evavirseda
Copy link
Contributor

@evavirseda evavirseda commented Nov 19, 2024 •
edited
Loading

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes #4076
fixes #4069

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@evavirseda evavirseda requested review from a team as code owners November 19, 2024 15:57
@evavirseda evavirseda self-assigned this Nov 19, 2024
@evavirseda evavirseda linked an issue Nov 19, 2024 that may be closed by this pull request
Add darkmode support: improve UI Kit components #4076
Open
4 tasks
@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 28be9ff

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-4elo5gfw3.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 28be9ff

✅ Preview: https://apps-ui-8pzv5okhs-iota1.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 28be9ff

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-l5lvqd390.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 28be9ff

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-d6lc7rnbh.vercel.app

@evavirseda evavirseda added team-tooling Issues related to the Tooling team apps-ui-kit Issues related to the Apps UI Kit labels Nov 19, 2024
@evavirseda evavirseda linked an issue Nov 20, 2024 that may be closed by this pull request
Add darkmode support for the Loading data indicator #4069
Open
@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 4b1a935

✅ Preview: https://apps-ui-ios21a7n2-iota1.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 4b1a935

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-zbkqmxb5h.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 4b1a935

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-kt5zl936x.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 4b1a935

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-nz2735n5m.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 83e04d7

✅ Preview: https://apps-ui-fbc761vio-iota1.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 83e04d7

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-nhsfu1m6o.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 83e04d7

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-8pmq94mi8.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 83e04d7

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-kvrgnahc9.vercel.app

@evavirseda evavirseda mentioned this pull request Nov 20, 2024
Open
@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: fa4fd80

✅ Preview: https://apps-ui-pl0o9p0uf-iota1.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: fa4fd80

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-6xblfqjbq.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: fa4fd80

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-3tk1b56vh.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: fa4fd80

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-37apznran.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 7d67456

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-gl5ur2tli.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 7d67456

✅ Preview: https://apps-ui-4w0iax2ai-iota1.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 7d67456

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-cfn6p4e6e.vercel.app

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 7d67456

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-oz7u61lng.vercel.app

brancoder
brancoder approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancoder brancoder brancoder approved these changes

Assignees

@evavirseda evavirseda

Labels
apps-ui-kit Issues related to the Apps UI Kit team-tooling Issues related to the Tooling team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add darkmode support: improve UI Kit components Add darkmode support for the Loading data indicator
2 participants
@evavirseda @brancoder