fix(iota): fix DisplayMetadata when validator is pending #3611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: DaughterOfMars <[email protected]>
DaughterOfMars
approved these changes
Oct 24, 2024
samuel-rufi
approved these changes
Oct 28, 2024
miker83z
approved these changes
Oct 28, 2024
piotrm50
approved these changes
Oct 28, 2024
8 tasks
stefan-mysten
pushed a commit
to MystenLabs/sui
that referenced
this pull request
Nov 25, 2024
…20354) ## Description Fix the DisplayMetadata command when a validator is still pending Without this change the ValidatorV1 can't be correctly decoded as the first bytes of the bcs are for the `Field` as the object is a dynamic field resulting in this error: `Can't convert bcs bytes of object 0x17792bdce1d0c032e64f5dff96a4e80eb453ab43f290ef6d091b1ebe50a511eb to ValidatorV1: malformed utf8` Porting the fix from iotaledger/iota#3611 ## Test plan Running these commands ``` # increase faucet amount (just setting 30 million didn't work) sed -i 's/200_000_000_000/4_000_000_000_000_000/g' crates/sui/src/sui_commands.rs cargo run start --force-regenesis --with-faucet # other terminal cargo install --locked --bin sui --path crates/sui sui client switch --env localnet # get enough coins sui client faucet --url http://127.0.0.1:9123/gas sui client faucet --url http://127.0.0.1:9123/gas sleep 2 sui validator make-validator-info validator0 description https://sui.io https://github.com/MystenLabs/sui 127.0.0.1 1000 sui validator become-candidate validator.info sleep 2 # stake enough coins for run in {1..8}; do coinObjectId=$(sui client gas --json | jq '.[0].gasCoinId') validatorAddress=$(sui client active-address) sui client call --package 0x3 --module sui_system --function request_add_stake --args 0x5 $coinObjectId $validatorAddress --gas-budget 10000000 done sleep 2 sui validator join-committee sleep 2 sui validator display-metadata ``` ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: Fixed the `sui validator display-metadata` command bug for pending validators. - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fix DisplayMetadata when validator is pending
Add test_become_validator
Links to any relevant issues
Fixes #2432
Fixes #2578
Type of change
How the change has been tested
Running the added test and also tested manually with the cli