Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Introduce Type Annotations #321

Merged
merged 3 commits into from
Mar 20, 2020
Merged

Conversation

lzpap
Copy link
Member

@lzpap lzpap commented Mar 19, 2020

Related Issues

#308, #317

Description

Introduce type annotations to enhance code readability and help static type checking and code analysis tools (mypy, PyCharm, etc.).

  • Remove type hints.
  • Annotate method arguments and return value.
  • Follow PEP-484 and PEP-8.

- Remove type hints.
- Follow PEP-484 and PEP-8.
Copy link
Contributor

@todofixthis todofixthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ questions+suggestions+thoughts.

iota/__init__.py Outdated Show resolved Hide resolved
iota/adapter/__init__.py Outdated Show resolved Hide resolved
iota/adapter/__init__.py Outdated Show resolved Hide resolved
iota/adapter/__init__.py Outdated Show resolved Hide resolved
iota/adapter/__init__.py Outdated Show resolved Hide resolved
iota/transaction/base.py Outdated Show resolved Hide resolved
iota/transaction/base.py Outdated Show resolved Hide resolved
iota/transaction/base.py Outdated Show resolved Hide resolved
iota/transaction/base.py Outdated Show resolved Hide resolved
iota/transaction/base.py Outdated Show resolved Hide resolved
Copy link
Contributor

@todofixthis todofixthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ questions+suggestions+thoughts.

@lzpap lzpap force-pushed the type_annotations branch from c7e5619 to 0e609ad Compare March 20, 2020 11:16
@lzpap lzpap merged commit 07f9a86 into iotaledger:develop Mar 20, 2020
@lzpap lzpap mentioned this pull request Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants