docs: Add Creating Transfers section
#316
Conversation
- get_signature_validation_trytes() renamed to get_bundle_essence_trytes() fo clarity.
- Explanation of how transfers are created - Two new figures on transfer creation and available API methods. - 3 code examples to show the different ways of transaction creation.
| def get_signature_validation_trytes(self): | ||
| def get_bundle_essence_trytes(self): |
There was a problem hiding this comment.
💭 This is probably low-level enough that it won't break any application logic, but maybe we should make this part of the next minor release (e.g., v2.3.0 => v2.4.0), just to be safe; what do you think?
There was a problem hiding this comment.
Probably no application uses it, unless it chooses to create the bundle hash itself.
It will be part of the next release, I'm just wondering what is the right approach here. We have in develop:
- the async changes, which is pretty big with dropping Python 2 and 3.5 support, and adding the asynchronous api.
- the new networking lib
httpxwith connection pooling is quite faster thanrequests. - renaming
testnettodevnet, this is a breaking change for apps that relied on it.
Should we include all these in a next minor release 2.4.0, or we say we move to PyOTA 3.0.0 since we dropped py 2 support anyway? 😺
Or we wait until summer and reserve PyOTA 3.0.0 for the chrysalis updates?
Probably there will also be some more extended api calls and maybe even account module coming before chrysalis though...
There was a problem hiding this comment.
Ooh, right. 🤔 Dropping Python 2 support is definitely big enough for a major release. Makes sense to me to bundle it all up in PyOTA 3.
There's no rule that says we have to wait for a long time between major releases; I figure there's no need to make devs wait until Chrysalis, even if that ends up being big enough to justify PyOTA 4 😸
Co-Authored-By: Phoenix <[email protected]>
Related Issues: #284 #268
Description
Other changes:
Transaction.get_transaction_validation_trytes()to better reflect its purpose.