Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Use class length for random TryteString generation #286

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

lzpap
Copy link
Member

@lzpap lzpap commented Jan 10, 2020

Solves: #166

Details

The base implementation for this PR was created in #167 by @rpitonak. Due to the merge conflicts, it was easier to re-implement in a new PR and add test coverage.

Changes:

  • Use cls.LEN as default length for TryteString's random classmethod.
  • Added test coverage.

If length is not specified in random()'s argument list,
it will be derived from the class LEN attribute.
Copy link
Contributor

@todofixthis todofixthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzpap lzpap merged commit 6e0b5c2 into iotaledger:develop Jan 14, 2020
@lzpap lzpap deleted the trytestring_randomlength branch January 28, 2020 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants