-
Notifications
You must be signed in to change notification settings - Fork 125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ suggestions
docs/basic_concepts.rst
Outdated
Transactions in the bundle are linked together through their ``branchTransaction`` | ||
and ``trunkTransaction`` fields, furthermore they are indexed within the bundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❕ I believe the client libraries rely exclusively on trunkTransaction
to link bundle transactions together; as far as I'm aware, branchTransaction
does not have any function beyond confirming a second tip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. What do you think about including such a picture to illustrate this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, ya, that looks good!
Before diving into the API, it's important to understand the fundamental | ||
data types of IOTA. | ||
|
||
:todo: Link to IOTA docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😹 omg how long has that been there??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
little more than 2 years 😸
6470a5c
to
c1b4dcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add a page describing basic IOTA concepts with references to the official docs site.
c1b4dcd
to
16226e8
Compare
Related issue #268
Changes
Basic Concepts
fromPyOTA Types
.Internal links to PyOTA classes and methods point to parts of the documentation that will be updated in future commits.