Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

docs: add Basic Concepts page #269

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Conversation

lzpap
Copy link
Member

@lzpap lzpap commented Nov 20, 2019

Related issue #268

Changes

  • Separate Basic Concepts from PyOTA Types.
  • Add a page describing basic IOTA concepts with references to the official docs site.

Internal links to PyOTA classes and methods point to parts of the documentation that will be updated in future commits.

Copy link
Contributor

@todofixthis todofixthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ suggestions

docs/basic_concepts.rst Outdated Show resolved Hide resolved
docs/basic_concepts.rst Outdated Show resolved Hide resolved
docs/basic_concepts.rst Outdated Show resolved Hide resolved
docs/basic_concepts.rst Outdated Show resolved Hide resolved
docs/basic_concepts.rst Outdated Show resolved Hide resolved
Comment on lines 137 to 138
Transactions in the bundle are linked together through their ``branchTransaction``
and ``trunkTransaction`` fields, furthermore they are indexed within the bundle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❕ I believe the client libraries rely exclusively on trunkTransaction to link bundle transactions together; as far as I'm aware, branchTransaction does not have any function beyond confirming a second tip.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. What do you think about including such a picture to illustrate this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, ya, that looks good!

docs/basic_concepts.rst Outdated Show resolved Hide resolved
docs/basic_concepts.rst Outdated Show resolved Hide resolved
docs/basic_concepts.rst Show resolved Hide resolved
Before diving into the API, it's important to understand the fundamental
data types of IOTA.

:todo: Link to IOTA docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😹 omg how long has that been there??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little more than 2 years 😸

@lzpap lzpap force-pushed the docs_basic_concepts branch from 6470a5c to c1b4dcd Compare November 21, 2019 09:37
Copy link
Contributor

@todofixthis todofixthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add a page describing basic IOTA concepts with references to
the official docs site.
@lzpap lzpap force-pushed the docs_basic_concepts branch from c1b4dcd to 16226e8 Compare November 22, 2019 09:18
@lzpap lzpap merged commit fdab9df into iotaledger:develop Nov 22, 2019
@lzpap lzpap deleted the docs_basic_concepts branch January 28, 2020 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants