Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Support adding/removing address checksums #265

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

lzpap
Copy link
Member

@lzpap lzpap commented Nov 15, 2019

Solves #254

Changes

Two new methods in Address class:

  • add_checksum: Appends a valid checksum to the Address object. Address.checksum attribute is updated and checksum trytes are appended to internal tryte buffer.
  • remove_checksum: Slices off the checksum from an Address object. Address.checksum attribute is updated (to value None) and internal tryte buffer is modified to hold only the 81 original address trytes.

@lzpap lzpap self-assigned this Nov 15, 2019
Copy link
Contributor

@todofixthis todofixthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend adding two more tests; otherwise LGTM

test/types_test.py Show resolved Hide resolved
test/types_test.py Show resolved Hide resolved
Two new methods in Address class:

 - add_checksum: appends a valid checksum to
   the Address object.

 - remove_checksum: slices off the checksum from
   an Address object.
Copy link
Contributor

@todofixthis todofixthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzpap lzpap merged commit 2e73a66 into iotaledger:develop Nov 19, 2019
@lzpap lzpap deleted the address_methods branch January 28, 2020 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants