This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Refactor traverse_bundle into Extended Api Command #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Provide the same api calls as in the other iota libs. The difference between get_bundles and traverse_bundle is subtle: get_bundles validates the fetched bundle. Moved previous test cases related to traverse_bundle into new test file, refactored tests for get_bundles.
lzpap
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #252
Description
Refactor
_traverse_bundlemethod fromiota.commands.extended.get_bundlesinto a standalone extended api command.Difference between
get_bundlesandtraverse_bundleextended api commands from user perspective is subtle:get_bundlesalso validates the fetched bundle.Motivation
Provide the same api calls as in other iota libs.
Additional Info
Moved previous test cases related to
traverse_bundlefromget_bundles_test.pyinto new test file, refactored tests forget_bundles.