Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Implement is_promotable Extended API Command #255

Merged
merged 2 commits into from
Nov 5, 2019

Conversation

lzpap
Copy link
Member

@lzpap lzpap commented Oct 30, 2019

Solves #251

Checks if a list of tail transaction hashes can be promoted or not by calling CheckConsistencyCommand core API and performing extra checks on the attachment_timestamp of the transactions fetched from the Tangle with GetTrytesCommand.

If all tails are promotable, the returned dict contains only a promotable key and True value.
If any of the tails are not promotable, promotable is False and the info key contains information about what went wrong.

Checks if a list of tails can be promoted or not by
calling checkConsistency core API and performing
extra checks on the attachment_timestamp of the
transactions fetched from the Tangle.
Copy link
Contributor

@todofixthis todofixthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ questions/suggestions.

iota/commands/extended/is_promotable.py Outdated Show resolved Hide resolved
iota/commands/extended/is_promotable.py Outdated Show resolved Hide resolved
test/commands/extended/is_promotable_test.py Outdated Show resolved Hide resolved
test/commands/extended/is_promotable_test.py Outdated Show resolved Hide resolved
@lzpap lzpap merged commit a68254d into iotaledger:develop Nov 5, 2019
@lzpap lzpap deleted the is_promotable branch January 28, 2020 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants