Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Corrected parameter-name 'start' to 'index'. #169

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Corrected parameter-name 'start' to 'index'. #169

merged 1 commit into from
Mar 29, 2018

Conversation

r-c-k
Copy link
Contributor

@r-c-k r-c-k commented Mar 28, 2018 •
edited by todofixthis
Loading

fixes #171

@todofixthis todofixthis changed the base branch from master to develop March 28, 2018 19:39
@todofixthis
Copy link
Contributor

Hey RK. Thanks for your pull request!

This change potentially breaks backwards compatibility for existing applications, so if we include this, I think it should wait until we're ready to release v2.1.

I do like the idea of keeping the parameter names consistent though. Could you add an issue to the PyOTA Issue Tracker so that we can keep track of it?

@todofixthis todofixthis self-assigned this Mar 28, 2018
@r-c-k
Copy link
Contributor Author

r-c-k commented Mar 29, 2018

Done.

@todofixthis
Copy link
Contributor

Ohhh, you were fixing the documentation! I thought you were changing the name of the parameter in the actual get_new_addresses() method.

jej... oops 😁

Right. This looks good; merging now. Thanks RK!

@todofixthis todofixthis merged commit 6e31c23 into iotaledger:develop Mar 29, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this pull request Jul 28, 2018
@todofixthis
Merge pull request iotaledger#169 from rckey/patch-1
6f407cc 
Corrected parameter-name 'start' to 'index' in documentation.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@todofixthis todofixthis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r-c-k @todofixthis @rckey