Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Obey PEP8 #145

Open
miili opened this issue Jan 21, 2018 · 7 comments
Open

Obey PEP8 #145

miili opened this issue Jan 21, 2018 · 7 comments

Comments

@miili
Copy link

miili commented Jan 21, 2018

Let's make the code conform with PEP8!

https://www.python.org/dev/peps/pep-0008/

The standard notation will make the code better readable.
Please give a short feedback... We (@HerrMuellerluedenscheid, @miili) could start on that.

@todofixthis
Copy link
Contributor

Hey guys. Thanks for suggesting this!

Here's what I put in CONTRIBUTING.rst:

  • Please ensure that your code conforms to PEP-8.
    • You may deviate from PEP-8 if you feel that your changes improve readability, but be aware that you may be asked to justify your decision.

If you'd like to take a firmer stance on PEP-8, I'm fine with that. Maybe we can add flake8 to the Travis CI build, so that PEP-8 compliance becomes part of the acceptance criteria for new pull requests.

@thcp
Copy link

thcp commented Jan 21, 2018

Well, since I have some free type and star citizen will not launch this year, I'm open to contribute by inspecting the code and refactor it if necessary.

@HerrMuellerluedenscheid
Copy link
Contributor

I did a quick flake8 (#146). Any comments about the employed style?

@thcp
Copy link

thcp commented Jan 21, 2018

So, I did a quick Insect before starting working on this and I noticed some violations. I'm going to pick this up as soon as possible, but you guys should at least consider setting the identation of 4 instead of 2.

@todofixthis
Copy link
Contributor

I would be hard-pressed to argue against adopting standards in an open-source project (:

The 2.0.4 release will be delayed a bit while I figure out how to update the C extension, so that should give a decent-sized window to get these changes into the next release.

@todofixthis
Copy link
Contributor

It would also be super cool if we could integrate flake8 into the build process (random example).

marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
@todofixthis
Copy link
Contributor

We've made good progress on this. All of the package files are now PEP-8-ified. Next up is to reformat the tests (wanted to do this separately, to make it less likely that a regression would sneak in), and then I think that's it 😺

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants