-
Notifications
You must be signed in to change notification settings - Fork 125
Obey PEP8 #145
Comments
Hey guys. Thanks for suggesting this! Here's what I put in
If you'd like to take a firmer stance on PEP-8, I'm fine with that. Maybe we can add flake8 to the Travis CI build, so that PEP-8 compliance becomes part of the acceptance criteria for new pull requests. |
Well, since I have some free type and star citizen will not launch this year, I'm open to contribute by inspecting the code and refactor it if necessary. |
I did a quick |
So, I did a quick Insect before starting working on this and I noticed some violations. I'm going to pick this up as soon as possible, but you guys should at least consider setting the identation of 4 instead of 2. |
I would be hard-pressed to argue against adopting standards in an open-source project (: The 2.0.4 release will be delayed a bit while I figure out how to update the C extension, so that should give a decent-sized window to get these changes into the next release. |
It would also be super cool if we could integrate flake8 into the build process (random example). |
We've made good progress on this. All of the package files are now PEP-8-ified. Next up is to reformat the tests (wanted to do this separately, to make it less likely that a regression would sneak in), and then I think that's it 😺 |
Let's make the code conform with PEP8!
https://www.python.org/dev/peps/pep-0008/
The standard notation will make the code better readable.
Please give a short feedback... We (@HerrMuellerluedenscheid, @miili) could start on that.
The text was updated successfully, but these errors were encountered: