Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add extra check for getting identity history #1438

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

itsyaasir
Copy link
Contributor

Description of change

Fix and add extra versioning check for the can_get_historical_identity_data tests

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@itsyaasir itsyaasir requested a review from a team as a code owner November 25, 2024 08:45
@itsyaasir itsyaasir self-assigned this Nov 25, 2024
@itsyaasir itsyaasir added No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Nov 25, 2024
@itsyaasir itsyaasir requested a review from a team November 26, 2024 09:26
@itsyaasir itsyaasir merged commit a080ec6 into feat/identity-rebased-alpha Nov 26, 2024
1 check passed
@itsyaasir itsyaasir deleted the chore/fix-tests branch November 26, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants