Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versioning of on-chain Identity #1435

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Versioning of on-chain Identity #1435

merged 6 commits into from
Nov 27, 2024

Conversation

UMR1352
Copy link
Contributor

@UMR1352 UMR1352 commented Nov 22, 2024 •
edited
Loading

Description of change

Add support for versioning on-chain Identitys in order to allow the creation of backwards incompatible changes to Identity.

Requirements

Should be merged after #1430

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

@UMR1352 UMR1352 added Enhancement New feature or improvement to an existing feature Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Nov 22, 2024
@UMR1352 UMR1352 self-assigned this Nov 22, 2024
@UMR1352 UMR1352 requested a review from a team as a code owner November 22, 2024 15:26
@eike-hass eike-hass changed the base branch from feat/identity-rebased to feat/identity-rebased-alpha November 25, 2024 13:55
wulfraem
wulfraem requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@wulfraem wulfraem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would adding a test for an upgrade make sense here?

identity_iota_core/packages/iota_identity/sources/identity.move Outdated Show resolved Hide resolved
identity_iota_core/packages/iota_identity/sources/proposals/upgrade.move Show resolved Hide resolved
@UMR1352
Copy link
Contributor Author

UMR1352 commented Nov 26, 2024

Would adding a test for an upgrade make sense here?

It definitely would but it's not so easy to do. Especially with the limited time we have RN

@UMR1352 UMR1352 requested a review from a team November 27, 2024 13:57
@UMR1352 UMR1352 merged commit a970f25 into feat/identity-rebased-alpha Nov 27, 2024
1 check passed
@UMR1352 UMR1352 deleted the feat/move-package-versioning branch November 27, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsyaasir itsyaasir itsyaasir approved these changes

@wulfraem wulfraem wulfraem approved these changes

Assignees

@UMR1352 UMR1352

Labels
Added A new feature that requires a minor release. Part of "Added" section in changelog Enhancement New feature or improvement to an existing feature Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UMR1352 @wulfraem @itsyaasir