Remove dependency on identity_core default features

[frederikrothenberger]

Description of change

identity_did and identity_document depend on identity_core but do not turn off default features. This means that these crates cannot be compiled for wasm32-unknown-unknown without a dependency on js-sys.

Given the default features are not required, removing them makes these crates compatible across a wider range of compilation targets.

Type of change

Add an x to the boxes that are relevant to your changes.

• Bug fix (a non-breaking change which fixes an issue)
• Enhancement (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Fix

How the change has been tested

Existing test suite.

Change checklist

Add an x to the boxes that are relevant to your changes.

• I have followed the contribution guidelines for this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[frederikrothenberger]

@itsyaasir: I ran into another issue related to js-sys, this time because I wanted to make use of identity_credential, which depends on identity_did and indentity_document.

[itsyaasir]

Hello! Thanks for doing this, I think this should be fine.

[itsyaasir]

@frederikrothenberger can you make sure everything is working well on your side before we merge this in ?

Thanks

[frederikrothenberger]

@itsyaasir: There are other features that we need (e.g. #1406) but in terms of compiling the library (at least the crates that we currently use) such that it works on the ICP platform, I can confirm that it works.

Thanks.

[frederikrothenberger]

@itsyaasir: Could this be merged?