Add support for StatusList2021 #1273

UMR1352 · 2024-01-08T08:53:51Z

Description of change

Implementation of StatusList2021

Type of change

Bug fix (a non-breaking change which fixes an issue)
Enhancement (a non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Fix

How the change has been tested

Unit and integration tests

Change checklist

I have followed the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

abdulmth

It looks great, thanks for working on it, some points that I noticed. This is not the full review, I will take a deeper look later.

identity_credential/Cargo.toml

identity_credential/src/credential/status.rs

identity_credential/src/revocation/status_list_2021/credential.rs

identity_credential/src/revocation/status_list_2021/status_list.rs

examples/1_advanced/7_status_list_2021.rs

identity_credential/src/revocation/status_list_2021/status_list.rs

abdulmth

Some more comments, I also would suggest moving the files of the old bitmap revocation method to a new directory under revocation and feature gate the status list into its own feature since it's not the same as bitmap, but it's under its feature.

identity_credential/src/revocation/status_list_2021/status_list.rs

identity_credential/src/revocation/status_list_2021/entry.rs

bindings/wasm/src/credential/revocation/status_list_2021/credential.rs

abdulmth · 2024-01-18T20:34:24Z

Also, please change the test number since the SD-JWT exampled is merged now, also Add the tests to the README files inside the examples directories, also to the node and cypress tests so they run for CI. Check the sd-jwt PR to see where they should be added.

eike-hass

Overall looking very good 💪 Left a view comments. Not everything needs to be addressed, but would like to have discussion on those topics

bindings/wasm/examples/src/1_advanced/7_status_list_2021.ts

bindings/wasm/src/credential/revocation/status_list_2021/credential.rs

bindings/wasm/examples/src/1_advanced/7_status_list_2021.ts

Co-authored-by: Eike Haß <[email protected]>

abdulmth

The improvements from the last review look great, thanks for working on it! I have some more comments, mainly on the rust example, whatever suggestions you decide to take should be also changed in the Wasm example. Also, some Wasm issues that need to be addressed, since wasm bindgen is weird sometimes.

examples/1_advanced/8_status_list_2021.rs

bindings/wasm/src/credential/revocation/status_list_2021/entry.rs

bindings/wasm/src/credential/revocation/status_list_2021/status_list.rs

bindings/wasm/src/credential/revocation/status_list_2021/credential.rs

abdulmth

Last minor comments

identity_credential/src/revocation/status_list_2021/credential.rs

bindings/wasm/examples/src/1_advanced/7_status_list_2021.ts

bindings/wasm/src/credential/revocation/status_list_2021/entry.rs

abdulmth · 2024-01-24T11:30:56Z

examples/1_advanced/8_status_list_2021.rs

+    serde_json::from_str::<StatusList2021Credential>(status_list_credential_json.as_str()).unwrap();
+
+  // Set the value of the chosen index entry to true to revoke the credential
+  status_list_credential.set_credential_status(&mut credential, credential_index, true)?;


We could've combined them to RevokedOrSuspended since that represents the 1 value better and the purpose is not relevant anyways. I added a suggestion to change the value parameter to something more descriptive if you want to keep it the way it is.

UMR1352 added 13 commits December 14, 2023 14:23

StatusList2021

97ab614

StatusList2021Credential

1ff7b62

StatusList2021Entry

5b56932

Multiple CredentialStatuses

05107b9

conversions between statuses, fix test

d9d07e9

StatusList2021Credential deserializable

3800ab4

test revocation checking with statuslist2021

a97bf6f

WASM bindings

1282cb7

example

71ca5fc

example enhancement

9c7b91b

wasm bindings example

57dd0d1

License

4dbfc67

docs

914cf9f

UMR1352 added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Jan 16, 2024

make clippy happy

b5d5d6f

UMR1352 added Documentation Improvements or additions to documentation. Excludes from changelog Added A new feature that requires a minor release. Part of "Added" section in changelog labels Jan 16, 2024

clippy again

a5b054e

UMR1352 marked this pull request as ready for review January 16, 2024 10:17

UMR1352 requested a review from abdulmth January 16, 2024 10:19

UMR1352 added 4 commits January 16, 2024 12:24

fmt

425774a

fmt & clippy

4b3ed99

license template

19d4aad

revocation feature gate

311bbb5

abdulmth suggested changes Jan 16, 2024

View reviewed changes

UMR1352 added 4 commits January 17, 2024 16:38

review comments

77f56fe

fix bindings

d961fef

dprint fmt

7993eb3

credential status refactor

bf8b302

abdulmth suggested changes Jan 18, 2024

View reviewed changes

status list review comment

029d0f1

UMR1352 requested a review from a team as a code owner January 19, 2024 10:16

UMR1352 and others added 7 commits January 19, 2024 17:20

status list credential PR comments

a3b5161

Review comments

467be81

Fix WASM bindings

b8083b1

Merge branch 'main' into feat/status-list-2021

5d5635b

Fix merge issue

f28996b

dprint fmt

292af3c

cargo clippy

2adef48

eike-hass requested changes Jan 22, 2024

View reviewed changes

UMR1352 added 3 commits January 22, 2024 17:44

bindings tests

18e2002

review comments

f076118

wasm example

8b53ddb

eike-hass reviewed Jan 23, 2024

View reviewed changes

bindings/wasm/examples/src/1_advanced/7_status_list_2021.ts Show resolved Hide resolved

eike-hass approved these changes Jan 23, 2024

View reviewed changes

Update bindings/wasm/examples/src/1_advanced/7_status_list_2021.ts

23283a8

Co-authored-by: Eike Haß <[email protected]>

abdulmth suggested changes Jan 23, 2024

View reviewed changes

UMR1352 added 2 commits January 24, 2024 11:31

review comments

fd8f1c2

clippy

2852a53

abdulmth approved these changes Jan 24, 2024

View reviewed changes

review comments

f1e29b7

abdulmth approved these changes Jan 24, 2024

View reviewed changes

UMR1352 merged commit 8bc3ab7 into main Jan 24, 2024
11 checks passed

eike-hass deleted the feat/status-list-2021 branch January 24, 2024 16:02

eike-hass linked an issue Jan 26, 2024 that may be closed by this pull request

[Task] Implement Status List 2021 #1277

Closed

8 tasks

UMR1352 mentioned this pull request Jan 29, 2024

[Task] Implement Status List 2021 #1277

Closed

8 tasks

eike-hass changed the title ~~Feat/status list 2021~~ Add support for StatusList2021 Feb 1, 2024

eike-hass removed the Documentation Improvements or additions to documentation. Excludes from changelog label Mar 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for StatusList2021 #1273

Add support for StatusList2021 #1273

UMR1352 commented Jan 8, 2024 •

edited

Loading

abdulmth left a comment

abdulmth left a comment •

edited

Loading

abdulmth commented Jan 18, 2024

eike-hass left a comment

abdulmth left a comment

abdulmth left a comment

abdulmth Jan 24, 2024

Add support for StatusList2021 #1273

Add support for StatusList2021 #1273

Conversation

UMR1352 commented Jan 8, 2024 • edited Loading

Description of change

Type of change

How the change has been tested

Change checklist

abdulmth left a comment

Choose a reason for hiding this comment

abdulmth left a comment • edited Loading

Choose a reason for hiding this comment

abdulmth commented Jan 18, 2024

eike-hass left a comment

Choose a reason for hiding this comment

abdulmth left a comment

Choose a reason for hiding this comment

abdulmth left a comment

Choose a reason for hiding this comment

abdulmth Jan 24, 2024

Choose a reason for hiding this comment

UMR1352 commented Jan 8, 2024 •

edited

Loading

abdulmth left a comment •

edited

Loading