Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated stronghold crate #1243

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Conversation

PhilippGackstatter
Copy link
Contributor

Description of change

Add dedicated stronghold crate with the same motivation as #1238, i.e. be more agnostic over the JwkStorage.

Links to any relevant issues

part of #1103

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Tests were ported / copied over from identity_storage.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@PhilippGackstatter PhilippGackstatter added Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Sep 22, 2023
@PhilippGackstatter PhilippGackstatter added this to the v0.7 Features milestone Sep 22, 2023
@eike-hass
Copy link
Collaborator

@PhilippGackstatter do you think the version bump for the release will work on the new crate too?

@PhilippGackstatter
Copy link
Contributor Author

@eike-hass Just checked. Yes it does 👍.

@PhilippGackstatter PhilippGackstatter merged commit b5f5f76 into main Sep 26, 2023
13 checks passed
@PhilippGackstatter PhilippGackstatter deleted the feat/stronghold-crate branch September 26, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants