Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Leaving dust when sending transaction #7412

Merged
merged 9 commits into from
Sep 13, 2023
Merged

Fix: Leaving dust when sending transaction #7412

merged 9 commits into from
Sep 13, 2023

Conversation

brancoder
Copy link
Collaborator

Summary

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@brancoder brancoder changed the base branch from develop to fix/insufficient-funds September 12, 2023 07:25
Base automatically changed from fix/insufficient-funds to develop September 12, 2023 15:50
begonaalvarezd
begonaalvarezd requested changes Sep 12, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks amazing, just left a minor comment 🙏🏼

packages/shared/components/inputs/AssetAmountInput.svelte Outdated Show resolved Hide resolved
@begonaalvarezd begonaalvarezd changed the base branch from develop to release/desktop-2.1.7 September 13, 2023 09:17
@begonaalvarezd begonaalvarezd changed the base branch from release/desktop-2.1.7 to develop September 13, 2023 09:54
begonaalvarezd

This comment was marked as outdated.

Sign in to view

begonaalvarezd
begonaalvarezd approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@begonaalvarezd begonaalvarezd merged commit d168f57 into develop Sep 13, 2023
4 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/insufficient-funds-for-dust branch September 13, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@msarcev msarcev Awaiting requested review from msarcev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Insufficient funds error when leaving dust
2 participants
@brancoder @begonaalvarezd