Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change searchable dropdowns to angular material autocomplete #1066

Merged
merged 10 commits into from
Jun 12, 2024

Conversation

IlinaGergova
Copy link
Contributor

@IlinaGergova IlinaGergova commented Jun 3, 2024

Background

Current searchable dropdowns have some issues (like #825 #824 #759).

Aim

To use Angular Material Autocomplete for these dropdowns.

Implementation

Searchable dropdown places:

  • Gene Browser
  • Home page
  • Pheno measure selector (Phenotype tool)
  • Gene sets

@IlinaGergova IlinaGergova reopened this Jun 3, 2024
@IlinaGergova IlinaGergova marked this pull request as draft June 3, 2024 07:23
Copy link
Contributor

@joankosev joankosev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • search in gene browser should de-select automatically when a gene is selected
  • remove animations: when the dropdown opens and when an item is clicked
  • CSS rules should be moved to styles.css
  • pheno measure selector should update state when deleting from the input field
  • last selected item (after deselection) is not highlighted again in the dropdown menu when cycling with arrow keys
  • pheno measure dropdown has a delay when clearing the input field; if possible try to speed it up

@IlinaGergova IlinaGergova requested a review from joankosev June 6, 2024 10:28
@IlinaGergova IlinaGergova marked this pull request as ready for review June 6, 2024 10:28
@IlinaGergova IlinaGergova changed the title change pheno measures dropdown to angular material autocomplete change searchable dropdowns to angular material autocomplete Jun 7, 2024
@joankosev
Copy link
Contributor

remove animations: when the dropdown opens and when an item is clicked
gene browser: when selecting a gene with Enter, it doesn't close the dropdown
pheno measure selector should update state when deleting from the input field (select a measure with the arrow keys; this will leave the focus in the input field. now you can delete with backspace and the state will still be correct. the moment the input field changes, the state should be updated accordingly.)

@IlinaGergova IlinaGergova force-pushed the angular-material-dropdowns branch from 68aea9c to 70df0e5 Compare June 12, 2024 11:38
@IlinaGergova IlinaGergova merged commit 403af4e into master Jun 12, 2024
1 check passed
@IlinaGergova IlinaGergova deleted the angular-material-dropdowns branch June 12, 2024 11:49
Copy link

sentry-io bot commented Jun 13, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Uncaught (in promise): TypeError: Cannot read properties of undefined (reading 'nativeElement') <anonymous>(src/app/gene-browser/gene-browser.c... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants