Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Features #18

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

New Features #18

wants to merge 10 commits into from

Conversation

alexsteinerde
Copy link

@alexsteinerde alexsteinerde commented May 24, 2018

Hey,

I added some new features to the library that I need for myself.
I would appreciate it if you accept this request so others can also use the new features of changing the size and background color of a specific item.
It would also be great if you push the new podspec file to the default repository.
fixes #17

Thanks for your great work.

@felixLam
Copy link
Member

Hi @alexsteinerde, Thank you for your PR. We greatly appreciate your contribution. However, we strive to keep diffs and PRs as small as possible. Large diffs require developers using this component to check more code when updating the dependency. Would you mind reverting your code style changes and adhere to the code style of this repository to minimise the diff?

@alexsteinerde
Copy link
Author

@felixLam I reverted some changes to make the number of diffs as small as possible. At every new code I use the new style code now but this changes already produced diffs in the code.
Is this what you mean?

@alexsteinerde
Copy link
Author

I would appreciate an acceptance of this pull request. Or if you have any other requirements, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom item width
2 participants