Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tar files in repo with pkglist = [ "all" ] #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skwsk
Copy link

@skwsk skwsk commented Nov 7, 2022

The current code doesn't work well with tar files in repo directory:

  1. If pkglist has list of tar file name, it has a few issues including issue GISO build failed with tar files including sysadmin in repo and pkglist has list of tar file names #22 and ciso_rpm_files (typo, should be cisco_rpm_files) is keep growing with duplicated items #23
  2. If pkglist is empty, only rpm files in repo directory are used, ignore tar files
  3. If pkglist = [ 'all' ], the GISO built without any SMUs in tar files.

This PR fixed for 3rd one (Fix #25). With this code change, if tar files in repo directory and pkglist = [ 'all' ], GISO created successfully. Key changes:

  • Too many wrongly nested loop for repo_paths
  • filepath for tar file is wrong, directory path added to the full path of tar file incorrectly
  • repo_files should be initialized only at start of validate_and_return_list()

And additional minor fix included to fix log message related with third party SMU (same as PR#10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eXR GISO build, tar files in repo directory with pkglist="all" doesn't work
1 participant