Correct read_dir(...) nlink/blocks reporting #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When requested via "--list --json" read_dir(...) loops thru AFCKeyValueRead(...) to obtain st_size/st_mtime/st_birthtime/st_nlink/st_blocks of each directory entry. Likely typo had st_nlink value being overwritten by st_blocks value causing reported "st_nlink" to match st_blocks and st_blocks always be "-1". Fix corrects this small typo and now both values are being reported correctly in this case.
|
Thanks for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requested via "--list --json", read_dir(...) loops thru AFCKeyValueRead(...) to obtain st_size/st_mtime/st_birthtime/st_nlink/st_blocks of each directory entry. Likely typo had st_nlink value being overwritten by st_blocks causing reported "st_nlink" to match st_blocks and st_blocks always be "-1". Fix corrects this typo and now both values are being reported correctly.