Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring list of error messages up-to-date. #232

Merged
merged 1 commit into from
May 26, 2016
Merged

Bring list of error messages up-to-date. #232

merged 1 commit into from
May 26, 2016

Conversation

jakepetroules
Copy link

@jakepetroules jakepetroules commented May 26, 2016

Automatically generated using MobileDevice.framework private APIs using a tool I hacked together.

Xcode 7.3.1 and OS X 10.11.5.

Automatically generated using MobileDevice.framework private APIs.
Xcode 7.3.1 and OS X 10.11.5.
@shazron
Copy link

shazron commented May 26, 2016

Thanks! Once the Travis CI checks pass, I'll pull this in.

@shazron shazron added this to the 2.0.0 milestone May 26, 2016
@akofman
Copy link

akofman commented May 26, 2016

Excellent !

@shazron shazron merged commit 26f981e into ios-control:master May 26, 2016
@jakepetroules
Copy link
Author

jakepetroules commented May 26, 2016

I'd recommend just using the APIs directly rather than hardcoding the error strings, so that we don't have to keep updating it. We're making that change in Qt Creator 4.1 as well. See that or my linked tool for guidance. I don't have a lot of time to spend on this so I'll leave that exercise to someone else. :)

Side benefit: the returned strings can be localized.

@jakepetroules jakepetroules deleted the codes branch May 26, 2016 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants