-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding auto-tracing for MongoDB #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolanos
previously approved these changes
Sep 9, 2019
mrickard
force-pushed
the
issue/65-mongodb-autotrace
branch
from
September 17, 2019 19:35
ff1575d
to
9a07277
Compare
kolanos
previously approved these changes
Sep 17, 2019
kolanos
previously approved these changes
Sep 19, 2019
kolanos
previously approved these changes
Sep 25, 2019
Adding MongoDB to index Adding MongoDB to README Adding bulkWrite detection, refactoring method of deriving trace key Refactoring MongoDB tests with connection convenience method (uses MongoDB-preferred connection params) Refactoring post-linting Additional way of detecting host and port for insert/find/update/delete methods. Replacing copy-paste duplication Refactor of host/port extraction, support for separate delivery of bulk commands in request.data, expanding traced cursor ops. Refactoring timeline test, adding callback to bulkWrite test, delinting Commented-code cleanup, commenting out tests that depend on MongoDB in the local environment, so that CircleCI passes. Updating MongoDB auto-trace info in README Explicitly awaiting plugin load in trace constructor Capitalization change to dbType for compatibility with Python collector Removing commented-out logs in test.
mrickard
force-pushed
the
issue/65-mongodb-autotrace
branch
from
September 25, 2019 15:57
30e502f
to
6f2274b
Compare
Updated capitalization for compatibility with Python agent. Last update before release. |
kolanos
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65