Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payload field plugins[].enabled should always be boolean #296

Closed
kolanos opened this issue Sep 28, 2018 · 1 comment
Closed

Payload field plugins[].enabled should always be boolean #296

kolanos opened this issue Sep 28, 2018 · 1 comment

Comments

@kolanos
Copy link
Contributor

kolanos commented Sep 28, 2018

If a plugin passes through the string value of a IOPIPE_*_ENABLED environment variable, the agent should properly cast any string/numeric value to a boolean.
@pselle
Copy link
Contributor

pselle commented Sep 28, 2018 •
edited
Loading

@kolanos is there an example where this didn't happen? I'd like to fix the source plugin that's violating this as well

kolanos added a commit to kolanos/iopipe that referenced this issue Sep 28, 2018
@kolanos
fix(strToBool): Cast plugins[].enabled as boolean
e321d55 
Closes iopipe#296
kolanos added a commit to kolanos/iopipe that referenced this issue Sep 28, 2018
@kolanos
fix(strToBool): Cast plugins[].enabled as boolean
b4d2390 
Closes iopipe#296
@kolanos kolanos mentioned this issue Sep 28, 2018
Merged
kolanos added a commit that referenced this issue Sep 28, 2018
@kolanos
fix(strToBool): Cast plugins[].enabled as boolean (#297)
050b08e 
* fix(strToBool): Cast plugins[].enabled as boolean

Closes #296

* Ading test for strToBool

* Move type checks into meta condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kolanos @pselle