Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Pull request template #86

Merged
merged 2 commits into from
May 25, 2022
Merged

add Pull request template #86

merged 2 commits into from
May 25, 2022

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented May 25, 2022

@MathewBiddle this one should help us remember the steps we need to check when sending a PR. Do you have anything to add or modify here?

@ocefpaf ocefpaf marked this pull request as ready for review May 25, 2022 15:09
@ocefpaf ocefpaf requested a review from MathewBiddle May 25, 2022 16:34
MathewBiddle
MathewBiddle approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@MathewBiddle MathewBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice. Interested to see it in action!

@ocefpaf
Copy link
Member Author

ocefpaf commented May 25, 2022 •
edited
Loading

This is nice. Interested to see it in action!

We don't need to test the notebooks here. Let's merge and we can tweak the template as we go.

@ocefpaf ocefpaf merged commit 768544d into ioos:main May 25, 2022
@ocefpaf ocefpaf deleted the add_pr_template branch May 25, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathewBiddle MathewBiddle MathewBiddle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocefpaf @MathewBiddle