Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove colab link and run notebook for map #41

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

MathewBiddle
Copy link
Contributor

noticed the colab link was in the top of the notebook.

Also, the map at the bottom isn't displaying. I thought if I ran it again and saved the map state it would display in jupyterbook. Maybe not? Issue with ipyleaflets in jupyter?

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ocefpaf
Copy link
Member

ocefpaf commented Nov 17, 2021

noticed the colab link was in the top of the notebook.

I thought you added that on purpose 😄
But yeah, we don't really need that b/c there is one in the drop down menu.

Also, the map at the bottom isn't displaying. I thought if I ran it again and saved the map state it would display in jupyterbook. Maybe not? Issue with ipyleaflets in jupyter?

In theory that is all that is needed. Let's merge and find out.
(I had trouble with that in the past before and had to parse the HTML by hand.)

@ocefpaf ocefpaf merged commit 4e2ce38 into ioos:main Nov 17, 2021
@MathewBiddle MathewBiddle deleted the patch-1 branch August 31, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants