Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures #39

Merged
merged 3 commits into from
Oct 20, 2021
Merged

Fix CI failures #39

merged 3 commits into from
Oct 20, 2021

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Oct 20, 2021

Two notebooks are failing with the latest version of iris. At some point it may be worth re-writing them with xarray.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 20, 2021

Only the data_management_notebooks/2020-10-10-GTS.ipynb is failing. It looks like http://osmc.noaa.gov/erddap is quite slow and returning a few 500s. I'm merging this for now so we can move forward with the two open PRs that are ready for review.

@ocefpaf ocefpaf merged commit eab92f7 into ioos:main Oct 20, 2021
@ocefpaf ocefpaf deleted the fix_CI_failures branch October 20, 2021 18:25
@MathewBiddle
Copy link
Contributor

I have a fix for that notebook

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 20, 2021

I have a fix for that notebook

Are you using another server/data source?

@MathewBiddle
Copy link
Contributor

see #12, have some fixes local that I'd like to push on that one.

@MathewBiddle
Copy link
Contributor

I have a fix for that notebook

Are you using another server/data source?

Yes. https://www.ndbc.noaa.gov/ioosstats/

I'll update that PR with my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants