Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery #181

Merged
merged 8 commits into from
Apr 17, 2024
Merged

Gallery #181

merged 8 commits into from
Apr 17, 2024

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Feb 19, 2024

Version 2 of #174. I'm still trying to optimize the script to avoid the manual adjustments to the markdown file.

Closes #173

This is not ready to be merged yet. We need to decide:

  • what "badges" we want: highlight package and keyword
  • image placeholder for notebooks that do not have a figure: make it smaller
  • Should the gallery be the only way to navigate the notebooks?
  • Add the keywords in the notebook for the badges (Bad idea.)

For the last one we will experiment with a main gallery with all the notebooks in a single place, and another one for each current category we have.

@MathewBiddle
Copy link
Contributor

Should the gallery be the only way to navigate the notebooks?

I like having the sidebar for folks who know where they want to go.

what "badges" we want: highlight package and keyword

Package/tool highlighted (R, Python, Plotly, pyobis, r-obis, etc.), topical keyword (dat mgmt, data access, etc.), data service (THREDDS, ERDDAP).

LMK when your ready for review.

@ocefpaf ocefpaf marked this pull request as ready for review April 11, 2024 13:39
@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 12, 2024

LMK when your ready for review.

It should be ready for a first pass.

@MathewBiddle
Copy link
Contributor

This looks good to me. I'm curious, did you write a script to create gallery.md?

I'll merge and we can make any fixes as needed. Really neat feature here.

@MathewBiddle MathewBiddle merged commit 9f81f4f into ioos:main Apr 17, 2024
11 checks passed
Copy link
Contributor

@MathewBiddle MathewBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a gallery page similar to notebooks_demos index
2 participants