This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
Update react-redux bindings to v7 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeyper
approved these changes
Aug 23, 2019
jpeyper
reviewed
Aug 23, 2019
|
|
||
| (_Object_): The subspaced store. | ||
|
|
||
| ## Examples |
There was a problem hiding this comment.
You might want to name each of these examples or give some description of what you are showing in the example. as right now it might be a bit messy.
|
Exciting news. Can't wait to have dynostore adapted so we can start testing/migrating our project. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm so sorry...
The long awaited PR upgrades pretty much everything to latest versions. The big ticket item here is moving to
react-reduxv7, including the change to the new context API.Along the way I also used some custom hooks for part of the functionality so I have also exposed them for wider use. Ideally we will revisit a hook API in the future as at the moment they are just return complete stores, but I'd rather offer some similar APIs to the ones provided by react-redux, e.g.
useNamespacedDispatch.There is a lot going on in this review... Too much, TBH. Good luck to the reviewers.