fix: Improve flag value resets between command executions #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for flags that contain slices as values, the defaul
CustomFlagResetBehaviour
func would actually callSet
which would appendflag.DefValue
to its previous value, rather than resetting to this default on command executions.I found this nifty little interface
SliceValue
to which we can cast ourpflag.Value
.SliceValue
exposesReset()
which we can use instead ofSet()
if the cast is successful.