✨ add clusterclass #55
Conversation
|
farodin91
force-pushed
the
add-preparation-of-clusterclass
branch
2 times, most recently
from
fdd3e8b to
5f0cb76
Compare
farodin91
requested review from
piepmatz,
lubedacht,
gfariasalves-ionos,
mcbenjemaa,
wikkyk and
jriedel-ionos
as code owners
farodin91
force-pushed
the
add-preparation-of-clusterclass
branch
from
5f0cb76 to
844e1f8
Compare
|
|
The PR lacks a bit of context in regards to your intentions. The title says preparations.. so is there a follow-up PR intended? If not we might also want to have a template and maybe a bit of docs/description in the PR so that people are well informed :) For instance like this https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/templates/clusterclass-template.yaml |
farodin91
force-pushed
the
add-preparation-of-clusterclass
branch
2 times, most recently
from
f7ff025 to
3559cca
Compare
Signed-off-by: Jan Jansen <[email protected]>
farodin91
force-pushed
the
add-preparation-of-clusterclass
branch
from
3559cca to
e58788a
Compare
|
farodin91
changed the title
|
i tested this with |
|
@lubedacht How to start the review process? I don't have yet an idea to add a test. |
| valueFrom: | ||
| template: | | ||
| - name: capv | ||
| sshAuthorizedKeys: | ||
| - '{{ .sshKey }}' | ||
| sudo: ALL=(ALL) NOPASSWD:ALL |
There was a problem hiding this comment.
In our base template the user is root. Also applies to the other patches in the file
| type: Opaque | ||
| stringData: | ||
| token: "${IONOS_TOKEN}" | ||
| apiURL: "${IONOS_API_URL:-https://api.ionos.com/cloudapi/v6}" |
There was a problem hiding this comment.
We aim to have newlines at the end of files.
Usually in your IDE you have a setting to append newlines when you save a file. I can recommend that setting.
There was a problem hiding this comment.
I tend to work with editorconfig everywhere.
| - name: sshKey | ||
| value: '${VSPHERE_SSH_AUTHORIZED_KEY}' |
There was a problem hiding this comment.
copy pasta.
Also we can provide multiple ssh keys with ${IONOSCLOUD_MACHINE_SSH_KEYS}. So you might want to use the plural form for the variable
|
Replaced by #141 |
What is the purpose of this pull request/Why do we need it?
We use clusterclass to automate updates and improve cluster handling.
Description of changes:
Add support for clusterclass
Checklist: