-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Provide new controller for handling generic load balancer provisioning #178
Merged
lubedacht
merged 19 commits into
feature/cp-load-balancing
from
implement-lb-controller
Jul 17, 2024
Merged
✨ Provide new controller for handling generic load balancer provisioning #178
lubedacht
merged 19 commits into
feature/cp-load-balancing
from
implement-lb-controller
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does this support cluster class? |
Clusterclass must also be supported yes. Currently the LB is a work in progress and a slightly bigger topic. |
lubedacht
force-pushed
the
implement-lb-controller
branch
from
July 12, 2024 08:50
e1f2d93
to
ed75d84
Compare
lubedacht
force-pushed
the
implement-lb-controller
branch
from
July 12, 2024 09:15
ed75d84
to
e1d380f
Compare
…noscloud into implement-lb-controller
lubedacht
requested review from
piepmatz,
gfariasalves-ionos,
mcbenjemaa,
wikkyk and
jriedel-ionos
as code owners
July 12, 2024 09:45
avorima
reviewed
Jul 16, 2024
avorima
reviewed
Jul 16, 2024
piepmatz
requested changes
Jul 16, 2024
avorima
reviewed
Jul 16, 2024
Quality Gate passedIssues Measures |
piepmatz
approved these changes
Jul 17, 2024
lubedacht
added a commit
that referenced
this pull request
Aug 30, 2024
…ing (#178) **What is the purpose of this pull request/Why do we need it?** This PR introduces a new controller to handle the setup of load balancing for the control plane. This PR does not provide the actual implementations as those will be done in separate PRs. As this is intended to provide an interface to work on multiple implementations at the same time, this branch will not be merged into main to not have an intermediate state. **Checklist:** - [x] Unit Tests added - [x] Includes [emojis](https://github.com/kubernetes-sigs/kubebuilder-release-tools?tab=readme-ov-file#kubebuilder-project-versioning)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request/Why do we need it?
This PR introduces a new controller to handle the setup of load balancing for the control plane. This PR does not provide the actual implementations as those will be done in separate PRs.
As this is intended to provide an interface to work on multiple implementations at the same time, this branch will not be merged into main to not have an intermediate state.
Checklist: