Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Provide new controller for handling generic load balancer provisioning #178

Merged
merged 19 commits into from
Jul 17, 2024

Conversation

lubedacht
Copy link
Contributor

@lubedacht lubedacht commented Jul 11, 2024

What is the purpose of this pull request/Why do we need it?

This PR introduces a new controller to handle the setup of load balancing for the control plane. This PR does not provide the actual implementations as those will be done in separate PRs.

As this is intended to provide an interface to work on multiple implementations at the same time, this branch will not be merged into main to not have an intermediate state.

Checklist:

  • Unit Tests added
  • Includes emojis

@farodin91
Copy link
Contributor

Does this support cluster class?

@lubedacht
Copy link
Contributor Author

Does this support cluster class?

Clusterclass must also be supported yes. Currently the LB is a work in progress and a slightly bigger topic.

@lubedacht lubedacht force-pushed the implement-lb-controller branch from e1f2d93 to ed75d84 Compare July 12, 2024 08:50
@lubedacht lubedacht force-pushed the implement-lb-controller branch from ed75d84 to e1d380f Compare July 12, 2024 09:15
@lubedacht lubedacht marked this pull request as ready for review July 12, 2024 09:45
@jriedel-ionos jriedel-ionos added this to the v0.3.0 milestone Jul 15, 2024
api/v1alpha1/ionoscloudloadbalancer_types.go Outdated Show resolved Hide resolved
api/v1alpha1/ionoscloudloadbalancer_types.go Outdated Show resolved Hide resolved
internal/controller/ionoscloudcluster_controller.go Outdated Show resolved Hide resolved
internal/controller/ionoscloudcluster_controller.go Outdated Show resolved Hide resolved
api/v1alpha1/ionoscloudloadbalancer_types_test.go Outdated Show resolved Hide resolved
internal/controller/ionoscloudcluster_controller.go Outdated Show resolved Hide resolved
internal/loadbalancing/provisioner.go Show resolved Hide resolved
internal/service/cloud/network.go Outdated Show resolved Hide resolved
api/v1alpha1/ionoscloudloadbalancer_types_test.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jul 17, 2024

@lubedacht lubedacht merged commit 217a8d2 into feature/cp-load-balancing Jul 17, 2024
8 checks passed
@lubedacht lubedacht deleted the implement-lb-controller branch July 17, 2024 12:40
lubedacht added a commit that referenced this pull request Aug 30, 2024
…ing (#178)

**What is the purpose of this pull request/Why do we need it?**

This PR introduces a new controller to handle the setup of load
balancing for the control plane. This PR does not provide the actual
implementations as those will be done in separate PRs.

As this is intended to provide an interface to work on multiple
implementations at the same time, this branch will not be merged into
main to not have an intermediate state.

**Checklist:**
- [x] Unit Tests added
- [x] Includes
[emojis](https://github.com/kubernetes-sigs/kubebuilder-release-tools?tab=readme-ov-file#kubebuilder-project-versioning)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants