feat: add transceiver getter to downtrack #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalekseevx
changed the title
aalekseevx
force-pushed
the
add-transceiver-getter
branch
from
3518131
to
f5ecf27
Compare
grahamking
approved these changes
Mar 11, 2023
|
@grahamking, Hi! Thanks for the review, are there any blockers for merging? |
grahamking
approved these changes
Apr 7, 2023
The project moved from the pion org, which I am part of, to 'ionorg', which I am not, so I can't approve it. And the 'ionorg' member list is not public, so 🤷♂️ not sure what to do here. @ojroques maybe you can review? |
|
I also suspect the This project might be abandoned. Maybe ask in the Pion Slack? |
|
I'm not part of the organization either. I can't help sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transceiver getter adds more flexibility to downtrack API, e.g. track Mid can be retrieved from downtrack. Also, transceiver setter is already present.