Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce friction #1918

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Reduce friction #1918

merged 6 commits into from
Sep 6, 2023

Conversation

stroborobo
Copy link
Contributor

@stroborobo stroborobo commented Aug 28, 2023

WHAT

🤖 Generated by Copilot at 3d47f79

This pull request updates various files related to the project's build, formatting, and configuration. It requires the .NET 7 SDK for building the project and adds the MSBuild.StructuredLogger package for parsing the build logs. It also removes an unnecessary flag from the fantomas command, adds the rollForward property to the global.json file, and syncs the .editorconfig and .gitattributes files. Finally, it updates the wsconfig.json schema file to include the dce option for the WebSharper compiler.

🤖 Generated by Copilot at 3d47f79

global.json changed
roll forward to latest features
autumn of .NET

📝🔧✨

WHY

I wanted to look into the new test discovery feature, but had some issues to get started. Like missing the exact dotnet version or fantomas/editorconfig and git not agreeing on line endings, causing changes where there should be none. So I tried to reduce the friction I experienced.

I don't know if these changes are in your interest, since they could be disruptive. For existing checkouts on non-Windows platforms for example, you'd need to delete and checkout all your files for the .fs CRLF change to be applied like this: git rm -rf --cached . && git reset --hard HEAD. (Destructive action! Commit first.)

HOW

🤖 Generated by Copilot at 3d47f79

  • Add MSBuild.StructuredLogger package to the build dependencies and references (link, link)
  • Remove redundant -r flag from the fantomas command in the Format target (link)
  • Update the .NET SDK version to .NET 7 and add the rollForward property to the global.json file (link, link, link)
  • Add comments to the .editorconfig and .gitattributes files to remind the contributors to keep them in sync (link, link)
  • Add the dce property to the wsconfig.json schema file for the bundle and bundleOnly project types (link)

Also update MSBuild.StructuredLogger, since dotnet 7.0.4 (sdk 7.0.202)
shipped with an a bump in the binlog version. Fake uses binlog as a
response from the dotnet process and crashed after using a newer sdk.
@stroborobo
Copy link
Contributor Author

Hey this Copilot for PRs is neat. Didn't change the actual content of wsconfig.json though, just line endings through the tool:
git add --renormalize .

@TheAngryByrd TheAngryByrd self-requested a review August 29, 2023 19:22
Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸 Thanks for this!

@TheAngryByrd TheAngryByrd merged commit 74e9802 into ionide:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants