Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update paket, fake, do paket update #902

Merged
merged 1 commit into from
Mar 19, 2022
Merged

update paket, fake, do paket update #902

merged 1 commit into from
Mar 19, 2022

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Mar 19, 2022

No description provided.

@dsyme
Copy link
Contributor Author

dsyme commented Mar 19, 2022 •
edited
Loading

@baronfel Looks like you have this covered in #890. I'm a bit perplexed by the test failures, are they heisentests in some way?

  Failed lsp.Ionide WorkspaceLoader.Go to definition tests.Script GoTo Tests.Go-to-definition on first char of identifier works [1 s]
  Failed lsp.Ionide WorkspaceLoader.Go to definition tests.Script GoTo Tests.cleanup [1 ms]

Also

Error: Access to the path '\\?\D:\a\FsAutoComplete\FsAutoComplete\test\FsAutoComplete.Tests.Lsp\TestCases\GoToTests\obj' is denied.

looks dodgy

@baronfel
Copy link
Contributor

We have some heisenbugs on windows for sure - you've hit them here. Reruns sometimes turn them green, and we just haven't invested the time in root-causing them.

@baronfel baronfel merged commit 2182f6a into ionide:main Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsyme @baronfel