Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't output a BOM to standard out #82

Merged
merged 1 commit into from
Oct 23, 2015

Conversation

rneatherway
Copy link
Contributor

@Krzysztof-Cieslak will this be a problem for you?

@lulu-berlin
Copy link

This PR works, in the sense that it doesn't emit a BOM. I replaced the fsautocomplete executable in the vim plugin with this one. It's still in utf-8, so vim-fsharp has some issues with that. I think it would make sense to solve them and have the benefit of being able to get information that contains non-ASCII characters (I haven't tested it, but I guess it would break in ASCII mode).

What I find puzzling is that this PR worked out of the box without the commit from the other PR that fixed the issue with the FSharp.Core reference... I seem to be getting different results with the zipped version and the built version...

@lulu-berlin
Copy link

Ok, I had to do a sanity check here. I reset my clone to the master branch and built the zip file (./build.cmd releasearchive). I unzipped it in a different directory, tested it and it runs perfectly without complaining about FSharp.Core.

Then I downloaded again the zip file of the last release (0.26.0), unzipped it and tested it --- and it fails again with the same error.

I don't know what magic happened between the release and the master branch (or is it the fact that I'm building it locally?), but the former fails and the latter works fine.

@Krzysztof-Cieslak
Copy link
Member

No problem at all, as I've moved to Suave based version in latest Ionide-fsharp version.

@rneatherway
Copy link
Contributor Author

Right, the issue was that to start with the Nuget package that was referenced was FSharp.Core 4.4.0.0. FsAutoComplete specified 4.3.0.0 so it used the version from my mono installation, which isn't properly signed. When you compile on Windows you get the proper MS signed version and everything is fine.

rneatherway added a commit that referenced this pull request Oct 23, 2015
Don't output a BOM to standard out
@rneatherway rneatherway merged commit f15d826 into ionide:master Oct 23, 2015
@rneatherway rneatherway deleted the no-stdout-bom branch October 23, 2015 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants