Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source link the netcore pdb files #266

Closed
wants to merge 13 commits into from
Closed

source link the netcore pdb files #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e712ddb
add sourcelink to netcore libraries
ctaggart Dec 26, 2017
7c57dc2
embed the paket files
ctaggart Dec 26, 2017
4d50bf8
print dotnet version info
ctaggart Dec 26, 2017
c1186d2
install current channel
ctaggart Dec 26, 2017
4a84c5a
ps: Invoke-WebRequest
ctaggart Dec 26, 2017
3d48f06
troubleshoot by printing FAKE dotnet version
ctaggart Dec 26, 2017
55f9a26
print the dotnet version from debug build
ctaggart Dec 26, 2017
a5c0d30
confirmed 2.1.3 is installed
ctaggart Dec 26, 2017
b0bcc5f
try dotnet restore before build
ctaggart Dec 26, 2017
74b2027
DotNetCli.Restore didn't help
ctaggart Dec 26, 2017
bb33d49
add paket group SourceLink
ctaggart Dec 26, 2017
bf0113b
bump to 2.6.1
ctaggart Dec 26, 2017
d0c9984
trigger CI rebuild
ctaggart Dec 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build.fsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ Target "BuildRelease" (fun _ ->

DotNetCli.Build (fun p ->
{ p with
Project = "FsAutoComplete.netcore.sln" })
Project = "FsAutoComplete.netcore.sln"
AdditionalArgs = [ "/p:SourceLinkCreate=true" ] })
)

let integrationTests =
Expand Down
8 changes: 7 additions & 1 deletion paket.dependencies
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ group Netcore
nuget System.Collections.Immutable
nuget OptimizedPriorityQueue


group Build
framework: net45
source https://www.nuget.org/api/v2/
Expand All @@ -57,3 +56,10 @@ group IntegrationTests
nuget Http.fs
nuget Newtonsoft.Json
nuget System.Net.WebSockets.Client

group SourceLink
storage: none
source https://www.nuget.org/api/v2/
nuget SourceLink.Create.CommandLine 2.6.1
nuget SourceLink.Embed.PaketFiles 2.6.1

7 changes: 7 additions & 0 deletions paket.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,6 +914,13 @@ NUGET
GITHUB
remote: Microsoft/visualfsharp
src/fsharp/FSharp.Build/Fsc.fs (cc1b137bc17f401a0cc669ff8fc598714d0fe652)
GROUP SourceLink
STORAGE: NONE
NUGET
remote: https://www.nuget.org/api/v2
SourceLink.Create.CommandLine (2.6.1)
SourceLink.Embed.PaketFiles (2.6.1)

GROUP Test
RESTRICTION: == net45
NUGET
Expand Down
2 changes: 2 additions & 0 deletions src/FsAutoComplete.Core.VerboseSdkHelper.netcore/FsAutoComplete.Core.VerboseSdkHelper.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

<ItemGroup>
<Compile Include="..\..\paket-files\netcore\Microsoft\visualfsharp\src\fsharp\FSharp.Build\Fsc.fs" />
<PackageReference Include="SourceLink.Create.CommandLine" Version="2.6.1" PrivateAssets="All" />
<PackageReference Include="SourceLink.Embed.PaketFiles" Version="2.6.1" PrivateAssets="All" />
</ItemGroup>

<Import Project="..\..\.paket\Paket.Restore.targets" />
Expand Down
2 changes: 2 additions & 0 deletions src/FsAutoComplete.Core.netcore/FsAutoComplete.Core.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@

<ItemGroup>
<ProjectReference Include="..\FsAutoComplete.Core.VerboseSdkHelper.netcore\FsAutoComplete.Core.VerboseSdkHelper.fsproj" />
<PackageReference Include="SourceLink.Create.CommandLine" Version="2.6.1" PrivateAssets="All" />
<PackageReference Include="SourceLink.Embed.PaketFiles" Version="2.6.1" PrivateAssets="All" />
</ItemGroup>

<Import Project="..\..\.paket\Paket.Restore.targets" />
Expand Down
2 changes: 2 additions & 0 deletions src/FsAutoComplete.netcore/FsAutoComplete.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

<ItemGroup>
<ProjectReference Include="..\FsAutoComplete.Core.netcore\FsAutoComplete.Core.fsproj" />
<PackageReference Include="SourceLink.Create.CommandLine" Version="2.6.1" PrivateAssets="All" />
<PackageReference Include="SourceLink.Embed.PaketFiles" Version="2.6.1" PrivateAssets="All" />
</ItemGroup>

<Import Project="..\..\.paket\Paket.Restore.targets" />
Expand Down