Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the signature of a constructor call if the symbol only gives us "unit" #1312

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

dawedawe
Copy link
Contributor

before:
image
after:
image

Also remove a superfluous space character.

Copy link
Contributor

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely targeted change

@dawedawe
Copy link
Contributor Author

Hey,
sorry if I'm annoying but I'm not sure about the process here anymore.
Is it on purpose that this approved PR is not merged or is there anything missing here?

@baronfel
Copy link
Contributor

Sorry @dawedawe, lost track of this one. Will merge now so it gets in the upcoming release.

@baronfel baronfel merged commit 2e2fd24 into ionide:main Aug 18, 2024
24 of 26 checks passed
@dawedawe
Copy link
Contributor Author

Cool, thanks!

@dawedawe dawedawe deleted the show_type_in_ctor_signature branch August 18, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants