fix: wrong "open" completion position with namespace #1300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix code completion for external namespace being inserted before
namespace
and bring backCompletion.AutoOpen
testsbefore :
after :
NB: I changed the position for
Namespace.fsx
&NamespaceWithNewLine.fsx
to match the actual behavior, it is correct F# syntax but I would have expected it to be aligned with the code below instead of thenamespace
(at least we get coverage for the inserted line part)NB2: Since I added back
Completion.AutoOpen
tests, I can't get the full test suite to run locally, the test adapter is crashing with OOM. Maybe the dedicatedcreateServer
function missed some "recent" optimisations applied to otherscreateServer
since it was not running until now ?