Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent compiler #1240

Merged
merged 60 commits into from
Apr 23, 2024
Merged
Show file tree
Hide file tree
Changes from 54 commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
0f513d8
Ignore warn on debug
TheAngryByrd Mar 1, 2024
1e365e9
global.json nonsense
TheAngryByrd Mar 1, 2024
973d47a
Transparent compiler changes
TheAngryByrd Mar 1, 2024
fe41e48
formatting
TheAngryByrd Mar 1, 2024
3732365
Fixing snapshots/caching
TheAngryByrd Mar 15, 2024
058f2cf
prototype adaptive snapshotting
TheAngryByrd Mar 19, 2024
a237930
Cleanup adaptive snapshots
TheAngryByrd Mar 19, 2024
b946e2c
Much refactoring snapshot tests
TheAngryByrd Mar 19, 2024
6e6ef62
Much refactoring snapshot tests
TheAngryByrd Mar 19, 2024
fa38c5f
Add adaptive snapshots to lsp server
TheAngryByrd Mar 21, 2024
316d371
Make source to snapshot lookup adaptive
TheAngryByrd Mar 21, 2024
e5c28ef
workspace cleanups
TheAngryByrd Mar 23, 2024
5c5f108
Fixup much stuff
TheAngryByrd Mar 25, 2024
eee5675
More cleanups
TheAngryByrd Mar 26, 2024
076dcea
undo some project selection and fix onsave checks
TheAngryByrd Mar 26, 2024
01a7100
Ensure project reloads happen correctly
TheAngryByrd Mar 31, 2024
13a9ddd
Enable all tests
TheAngryByrd Mar 31, 2024
8a87f44
formatting
TheAngryByrd Mar 31, 2024
cfefbd8
formatting
TheAngryByrd Mar 31, 2024
cd6898f
fix path normalization issues
TheAngryByrd Apr 15, 2024
7657d79
fix stacktraces when adaptive has failures
TheAngryByrd Apr 15, 2024
f53b339
fix normalization issues
TheAngryByrd Apr 15, 2024
d14232a
fixup stacktrackes
TheAngryByrd Apr 15, 2024
1e867f9
fixup tests
TheAngryByrd Apr 15, 2024
e3ed551
Add OTel to tests
TheAngryByrd Apr 15, 2024
690e722
formatting
TheAngryByrd Apr 15, 2024
623f2eb
remove future expecto features
TheAngryByrd Apr 15, 2024
64e653e
handle CI failures for file tests
TheAngryByrd Apr 16, 2024
a6657d9
Maybe make tests work on nix
TheAngryByrd Apr 16, 2024
1bb1ce3
fixing tests part 302
TheAngryByrd Apr 16, 2024
2d2f29c
fixing tests part 303
TheAngryByrd Apr 17, 2024
54749ee
fixing tests part 304
TheAngryByrd Apr 17, 2024
1ea1035
fixing tests part 305
TheAngryByrd Apr 17, 2024
dc39ae3
get more logging in github actions
TheAngryByrd Apr 17, 2024
249d1b6
fixing tests part 306
TheAngryByrd Apr 17, 2024
edfa450
fixing tests part 307
TheAngryByrd Apr 17, 2024
fe45c9c
fixing tests part 308
TheAngryByrd Apr 17, 2024
3ac6a90
cleanup
TheAngryByrd Apr 17, 2024
4caf366
refactoring
TheAngryByrd Apr 21, 2024
e499e3f
Add OTel to projectworkspace
TheAngryByrd Apr 21, 2024
bd2153c
add description to emptyfiletests
TheAngryByrd Apr 21, 2024
41c08aa
add retry to cursorbased tests
TheAngryByrd Apr 21, 2024
de76398
fix focustest helpers
TheAngryByrd Apr 21, 2024
36fcc73
add telplin
TheAngryByrd Apr 21, 2024
77aca9a
fix otel readme docs
TheAngryByrd Apr 21, 2024
ae52948
Make background/transparent compiler switchable
TheAngryByrd Apr 21, 2024
aa4f46e
Up timeout again
TheAngryByrd Apr 21, 2024
096cb02
Split up tests
TheAngryByrd Apr 22, 2024
88e430f
Retry workspace loader tests
TheAngryByrd Apr 22, 2024
cea27d2
skip flakey test
TheAngryByrd Apr 22, 2024
53baffe
disable projectgraph tests for perf reasons
TheAngryByrd Apr 22, 2024
c9e2ae0
Fix description of transparent compiler flag
TheAngryByrd Apr 22, 2024
560a44b
cleanup dead code
TheAngryByrd Apr 22, 2024
8696c11
Comment project workspace more
TheAngryByrd Apr 22, 2024
bba20b6
revert fsproj change
TheAngryByrd Apr 22, 2024
47bc364
Update src/FsAutoComplete.Core/AdaptiveExtensions.fs
TheAngryByrd Apr 22, 2024
00b911e
Update Directory.Build.props
TheAngryByrd Apr 22, 2024
48ad332
Remove nowarn since it's in pojectfile now
TheAngryByrd Apr 22, 2024
a6692eb
Remove redundant normalize call
TheAngryByrd Apr 22, 2024
5223f80
Add noequality no comparison
TheAngryByrd Apr 22, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .config/dotnet-tools.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@
"commands": [
"fsharp-analyzers"
]
},
"telplin": {
"version": "0.9.6",
"commands": [
"telplin"
]
}
}
}
12 changes: 10 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ jobs:
- macos-13 # using 13 because it's a bigger machine, and latest is still pointing to 12
- ubuntu-latest
dotnet-version: ["", "6.0.x", "7.0.x", "8.0.x"]
use-transparent-compiler:
- "TransparentCompiler"
- "BackgroundCompiler"
workspace-loader:
- "WorkspaceLoader"
# - "ProjectGraph" # this is disable because it just adds too much time to the build
# these entries will mesh with the above combinations
include:
# just use what's in the repo
Expand Down Expand Up @@ -61,7 +67,7 @@ jobs:

runs-on: ${{ matrix.os }}

name: Build on ${{matrix.os}} for ${{ matrix.label }}
name: Build on ${{matrix.os}} for ${{ matrix.label }} ${{ matrix.workspace-loader }} ${{ matrix.use-transparent-compiler }}

steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -102,11 +108,13 @@ jobs:
BuildNet8: ${{ matrix.build_net8 }}

- name: Run and report tests
run: dotnet test -c Release -f ${{ matrix.test_tfm }} --no-restore --no-build --no-build --logger GitHubActions /p:AltCover=true /p:AltCoverAssemblyExcludeFilter="System.Reactive|FSharp.Compiler.Service|Ionide.ProjInfo|FSharp.Analyzers|Analyzer|Humanizer|FSharp.Core|FSharp.DependencyManager" -- Expecto.fail-on-focused-tests=true --blame-hang --blame-hang-timeout 1m
run: dotnet test -c Release -f ${{ matrix.test_tfm }} --no-restore --no-build --logger "console;verbosity=normal" --logger GitHubActions /p:AltCover=true /p:AltCoverAssemblyExcludeFilter="System.Reactive|FSharp.Compiler.Service|Ionide.ProjInfo|FSharp.Analyzers|Analyzer|Humanizer|FSharp.Core|FSharp.DependencyManager" -- Expecto.fail-on-focused-tests=true --blame-hang --blame-hang-timeout 1m
working-directory: test/FsAutoComplete.Tests.Lsp
env:
BuildNet7: ${{ matrix.build_net7 }}
BuildNet8: ${{ matrix.build_net8 }}
USE_TRANSPARENT_COMPILER: ${{ matrix.use-transparent-compiler }}
USE_WORKSPACE_LOADER: ${{ matrix.workspace-loader }}

analyze:
runs-on: ubuntu-latest
Expand Down
4 changes: 3 additions & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@
<NoWarn>$(NoWarn);3186,0042</NoWarn><!-- circumvent an error with the fake dependencymanager for
paket: https://github.com/dotnet/fsharp/issues/8678 -->
<NoWarn>$(NoWarn);NU1902</NoWarn><!-- NU1902 - package vulnerability detected -->
<WarnOn>$(WarnOn);1182</WarnOn> <!-- Unused
<NoWarn>$(NoWarn);57</NoWarn>
TheAngryByrd marked this conversation as resolved.
Show resolved Hide resolved
<WarnOn Condition="'$(Configuration)' != 'Debug'">$(WarnOn);1182</WarnOn> <!-- Unused
variables,https://learn.microsoft.com/en-us/dotnet/fsharp/language-reference/compiler-options#opt-in-warnings -->

<WarnOn>$(WarnOn);3390</WarnOn><!-- Malformed XML doc comments -->
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<ChangelogFile>$(MSBuildThisFileDirectory)CHANGELOG.md</ChangelogFile>
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ To export traces, run [Jaeger](https://www.jaegertracing.io/)

```bash
docker run -d --name jaeger \
-e COLLECTOR_ZIPKIN_HOST_PORT=:9411 \
-e COLLECTOR_ZIPKIN_HOST_PORT=9411 \
-e COLLECTOR_OTLP_ENABLED=true \
-p 6831:6831/udp \
-p 6832:6832/udp \
Expand Down
4 changes: 2 additions & 2 deletions global.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"sdk": {
"version": "7.0.400",
"rollForward": "major",
"rollForward": "latestMajor",
"allowPrerelease": true
}
}
}
Loading
Loading