Merge nightly into main for the release! #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Maxime Mangel <[email protected]>
…Or is it? Meanwhile, adjust the reflection code to the changes in FCS.
- Update to latest FCS beta package
* Having the latest fsc, we can make use of the now public Range property of PreXmlDoc to save resources * format
* Update FCS to 43.8.100-preview.23455.5. * Update error code in test.
TheAngryByrd
approved these changes
Oct 21, 2023
4 tasks
* Update FCS to 43.8.100-preview.23523.6 * Pass in proper constant. * Update to 43.8.100 stable
auto-merge was automatically disabled
November 16, 2023 13:00
Pull Request is not mergeable
|
@nojaf you beautiful, wonderful, AMAZING human! I was struggling for so long trying to find that root cause. Let's merge this thing! |
|
Have to make a merge commit because we're merging the nightly branch in and I don't want future nightly -> main merges to lose history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 63fa1ad
This pull request updates the FsAutoComplete project to support F# 6.0 features and use the latest FCS API. It modifies several files that deal with syntax analysis, code generation, code fixes, and testing to handle the new syntax, error codes, and record types introduced in F# 6.0. It also updates the dependencies to use compatible versions of FCS and its nightly feed.
🤖 Generated by Copilot at 63fa1ad
🆕🛠️🗑️
WHY
We're close to release and there's a pretty stable set of packages. Lets go ahead and sync to main now that we're at that point in the lifecycle.
HOW
🤖 Generated by Copilot at 63fa1ad
src/FsAutoComplete.Core/UntypedAstUtils.fs,src/FsAutoComplete.Core/FCSPatches.fs) (link, link, link, link, link)src/FsAutoComplete.Core/Lexer.fs) (link)src/FsAutoComplete.Core/ParseAndCheckResults.fs) (link)src/FsAutoComplete.Core/ParseAndCheckResults.fs) (link)src/FsAutoComplete.Core/UnionPatternMatchCaseGenerator.fs) (link, link)src/FsAutoComplete.Core/UntypedAstUtils.fs) (link, link, link, link)src/FsAutoComplete.Core/UntypedAstUtils.fs) (link)src/FsAutoComplete.Core/UntypedAstUtils.fs) (link)src/FsAutoComplete/CodeFixes/AddMissingEqualsToTypeDefinition.fs,test/FsAutoComplete.Tests.Lsp/CodeFixTests/Tests.fs,test/FsAutoComplete.Tests.Lsp/ScriptTests.fs) (link, link, link, link)