Better Completion for ExternalAutocomplete functions #1178
Conversation
Add FullNameExternalAutocomplete
(for `module Result` added `open System.Diagnostics.Contracts.Contract`)
fix: completions with same label have same description add: filter completions by full name under fullNameExternalAutocomplete add: tests for fullNameExternalAutocomplete
There was a problem hiding this comment.
🎸 This looks great! Gonna let @baronfel make a review pass too.
| Kind = (AVal.force glyphToCompletionKind) d.Glyph | ||
| InsertText = Some code | ||
| InsertText = Some(getCodeToInsert d) |
There was a problem hiding this comment.
nit: getCodeToInsert d is calculate above in code - can we reuse it here to prevent recalculating?
| | Some no when config.FullNameExternalAutocomplete -> | ||
| // allow filter "Ceiling (System.Math)" by "System.Math.Ceiling" or "CeilingSystem.Math" | ||
| sprintf "%s (%s)" d.NameInList no, d.NameInList + code | ||
| | Some no -> sprintf "%s (open %s)" d.NameInList no, d.NameInList | ||
| | None -> d.NameInList, d.NameInList |
There was a problem hiding this comment.
can you describe in a comment the logic going on here? how does the label selection and the filter text impact the user experience of searching/filtering in the IDE?
The previous implementation didn't document why decisions were made, and so we don't have any sort of record for justification for making changes.
|
There's two ways to display conpletions label, one is like "AA.BB.CC" and another is "CC (AA.BB)".
When the full name is long, comparing to the second display way, the first one seems to be too messy, and can't quickly distinguish member's name.
So completions label is decided to display like "CC (AA.BB)". To enter part of the full name to filter completion items, the filter text must contain its full name "AA.BB.CC". As completions member name was the first part of the label, to make it first filter out by member name, and to make filtered label highlighted correctly by editors, the name must to be the first part of the filter text. As the result, the format of filter text is member name + full name, which is "CCAA.BB.CC". |
|
Thanks @Tangent-90 - that helps me understand the intent quite a bit more! |
|
Pushed a tiny change to add more to the docs so it was clearer to me personally, but otherwise this LGTM and let's ship it! Ideally we could also add the option to the Ionide package.json so that end users have some docs for it. |
Co-authored-by: Chet Husk <[email protected]>
TheAngryByrd
changed the title
Co-authored-by: Chet Husk <[email protected]>
WHAT
🤖 Generated by Copilot at b053be9
This pull request adds a new feature to the F# language server, which allows the user to configure how completion items for external symbols are displayed. It also improves the completion items for hash directives and keywords, and adds tests for the new feature. The main files affected are
src/FsAutoComplete.Core/KeywordList.fs,src/FsAutoComplete/LspHelpers.fs,src/FsAutoComplete/LspServers/AdaptiveFSharpLspServer.fs, andtest/FsAutoComplete.Tests.Lsp/CompletionTests.fs.🤖 Generated by Copilot at b053be9
🧑💻🔧🧪
WHY
Array.map"Before:
After:
Before:
After:
FullNameExternalAutocompleteBefore:
With
FullNameExternalAutocomplete:HOW
🤖 Generated by Copilot at b053be9
getCodeToInsertfunction and thedatafield of the completion items (link, link, link, link, link, link)labelfield and adatafield to the completion items for hash directives and keywords, using the#prefix for directives (link, link, link)fullNameExternalAutocompleteTestfunction and theRange.FullNameExternalAutocompletefield (link, link)