-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change location of symbolCache.db #912
Comments
This change in #913 seem to have broken running the server on non-windows systems. In particular, it creates a folder inside the current directory with a windows-style file path, which breaks the dotnet compiler. Since the vscode plugin is supposed to inject the appropriate path at startup wouldn't it make sense to keep the default state directory as something working across systems (like .ionide as previously)? |
It does default to the current directory as the root, the problem is entirely in how we construct the path here: https://github.com/fsharp/FsAutoComplete/blob/main/src/FsAutoComplete.Core/SymbolCache.fs#L104 |
This was released in 6.0.0 of ionide and 0.52.0 of FSAC. |
@Nsidorenco I'll put a PR up for this soon, and I've got a macos machine to test on now! |
@baronfel That great to hear! I managed to work around it by setting the state-directory manually but it would be great to get the default fixed! |
VSCode gives each extension a global and workspace-specific path to store state in the form of the following ExtensionContext properties:
We should update Ionide to flow those through as FSAC startup parameters, and FSAC should learn to take those as the location to store persistent state.
The text was updated successfully, but these errors were encountered: