Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up FSharp.CompilerBinding agent API #17

Closed
rneatherway opened this issue Jun 9, 2015 · 2 comments
Closed

Clean up FSharp.CompilerBinding agent API #17

rneatherway opened this issue Jun 9, 2015 · 2 comments

Comments

@rneatherway
Copy link
Contributor

From @rneatherway on October 22, 2014 15:58

Comment in FSharp.AutoComplete/Program.fs:

// TODO: Clean up the API these options are being generated to call
//
// That API is in FSharp.CompilerBinding.LanguageService.
// 1. It expects a Target Framework, but only for FSI as
// FCS is rumoured not to return references including FSharp.Core
// and it uses the framework to guess where it is.
// We will just use 4.5.
// 2. The CompileFiles just get added to the options, so we will do that
// here and then pass in an empty array of CompileFiles.

Any changes will also affect monodevelop binding.

Copied from original issue: fsprojects/zarchive-fsharpbinding#772

@rneatherway
Copy link
Contributor Author

From @7sharp9 on December 15, 2014 14:6

Is this now complete then?

@rneatherway
Copy link
Contributor Author

From @7sharp9 on April 29, 2015 15:51

I removed the XS label as this is no longer an issue there as its "evolving"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant