When removing a file clear its diagnostics (#1005)

* When removing a file clear its diagnostics

Related to ionide/ionide-vscode-fsharp#1768

* When removing it file from fsproj remove it also from the project options

Fix bug where the file was still being consider part of the project on FSAC resulting
in generating wrong diagnostic when editing the removed file.

* Fix formatting issues

src/FsAutoComplete.Core/Commands.fs

@@ -1343,9 +1343,10 @@ type Commands(checker: FSharpCompilerServiceChecker, state: State, hasAnalyzers:
       return CoreResponse.Res()
     }
 
-  member _.FsProjRemoveFile (fsprojPath: string) (fileVirtPath: string) =
+  member _.FsProjRemoveFile (fsprojPath: string) (fileVirtPath: string) (fullPath: string) =
     async {
       FsProjEditor.removeFile fsprojPath fileVirtPath
+      state.RemoveProjectOptions(normalizePath fullPath)
       return CoreResponse.Res()
     }
 

src/FsAutoComplete/LspServers/AdaptiveFSharpLspServer.fs

@@ -3708,8 +3708,12 @@ type AdaptiveFSharpLspServer(workspaceLoader: IWorkspaceLoader, lspClient: FShar
             >> Log.addContextDestructured "parms" p
           )
 
+          let fullPath = Path.Combine(Path.GetDirectoryName p.FsProj, p.FileVirtualPath)
           do! Commands.removeFile p.FsProj p.FileVirtualPath |> AsyncResult.ofCoreResponse
           loadedProjectOptions |> AVal.force |> ignore
+          let fileUri = Path.FilePathToUri fullPath
+          diagnosticCollections.ClearFor fileUri
+
           return { Content = "" }
         with e ->
           logger.error (

src/FsAutoComplete/LspServers/FsAutoComplete.Lsp.fs

@@ -2636,7 +2636,12 @@ type FSharpLspServer(state: State, lspClient: FSharpLspClient) =
           >> Log.addContextDestructured "parms" p
         )
 
-        let! res = commands.FsProjRemoveFile p.FsProj p.FileVirtualPath
+        let fullPath = Path.Combine(Path.GetDirectoryName p.FsProj, p.FileVirtualPath)
+        let! res = commands.FsProjRemoveFile p.FsProj p.FileVirtualPath fullPath
+        // Compute the fileUri, as this is the key used by the diagnostics collection.
+        let fileUri = Path.FilePathToUri fullPath
+
+        diagnosticCollections.ClearFor fileUri
 
         let res =
           match res with